[core] Introduce junit5 #4725
Merged
[core] Introduce junit5 #4725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigscoop
changed the title
|
for compatibility with Android, we need to leave it on Java 8 |
|
but the project can't be built with java 8 anymore |
Android supports 11 and 17 |
|
ping @timmolter @walec51 @makarid |
|
Android does not support full Java 11. Android is Java 8 plus features backported from newer versions. To bring back Android support we should add a CI Job that build a small example app that is build using Android SDK an that imports this library. Any one up for this task? |
|
Rolled back the code level changes. Now it is only junit 5 |
bigscoop
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
junit-vintage-engineto enable junit 5 runner, but leaving existing junit 4 tests available and untouched